Ghostscript (gstoraster): Introduce cupsHalftoneType dithering algorithms #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdohnal
requested changes
May 28, 2025
Member
zdohnal
left a comment
zdohnal
left a comment
There was a problem hiding this comment.
Looks the same as libcupsfilters one - I have the same comments: some code style and request for someone who understands the functionality better.
Member
|
Either way, thank you for the PR, @ValdikSS ! |
ValdikSS
force-pushed
the
ghostscript-dither-repo
branch
from
9e5bee7 to
035508c
Compare
Member
Author
Fixed, rebased and force-pushed. |
ValdikSS
force-pushed
the
ghostscript-dither-repo
branch
from
035508c to
394f816
Compare
Member
Author
Done |
zdohnal
requested changes
Jun 2, 2025
Member
zdohnal
left a comment
zdohnal
left a comment
There was a problem hiding this comment.
Thank you for the change - I have missed one place where we have to guard better against NULL, so it would be great if you looked into that.
zdohnal
requested changes
Jun 2, 2025
ValdikSS
force-pushed
the
ghostscript-dither-repo
branch
from
394f816 to
40a6d35
Compare
…thms Add new dithering (halftone) algorithms in addition to the default Ghostscript one. Controlled either with `halftone-type` job option or `cupsHalftoneType` PPD option. - Stochastic algotirhm is implemented in `stocht.ps` Ghostscript library, just include it if cupsHalftoneType is set to yes/true/on/stochastic. - Foo2zjs algorithm is a PostScript code taken from foo2zjs-pstops file (don't know the name of the algorithm)
Similar to pdftoraster implementation.
ValdikSS
force-pushed
the
ghostscript-dither-repo
branch
from
40a6d35 to
48de598
Compare
Member
Author
|
Removed the stray |
zdohnal
reviewed
Jul 9, 2025
zdohnal
reviewed
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything from libcupsfilters MR: OpenPrinting/libcupsfilters#92
Add new dithering (halftone) algorithms in addition to the default Ghostscript one.
Controlled either with
halftone-typejob option orcupsHalftoneTypePPD option.stocht.psGhostscript library, just include it if cupsHalftoneType is set to yes/true/on/stochastic.Default algorithm
Stochastic algorithm
Foo2zjs algorithm